danny0405 commented on code in PR #13229:
URL: https://github.com/apache/hudi/pull/13229#discussion_r2078727230
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/metadata/HoodieBackedTableMetadataWriter.java:
##########
@@ -1510,7 +1514,7 @@ protected HoodieData<HoodieRecord>
prepRecords(Map<String, HoodieData<HoodieReco
public void performTableServices(Option<String> inFlightInstantTimestamp,
boolean requiresTimelineRefresh) {
HoodieTimer metadataTableServicesTimer = HoodieTimer.start();
boolean allTableServicesExecutedSuccessfullyOrSkipped = true;
- BaseHoodieWriteClient<?, I, ?, ?> writeClient = getWriteClient();
+ BaseHoodieWriteClient<?, I, ?, O> writeClient = getWriteClient();
Review Comment:
apparantly this is an explicit use case for "auto-commit", why not just
support the inline completion for that in the write client, the developer needs
such flexibility, removing the auto-commit from executors is good but I'm
inclined to keep it in write client as public APIs(for MDT, for tests or for
other use cases).
We can by default mark the `shouldComplete` as false, but like Ethan
mentioned, we need to revisit all the callers that use the inline completion
API before.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
