n3nash commented on a change in pull request #2168:
URL: https://github.com/apache/hudi/pull/2168#discussion_r520133436
##########
File path:
hudi-integ-test/src/main/java/org/apache/hudi/integ/testsuite/HoodieTestSuiteJob.java
##########
@@ -147,7 +147,7 @@ public void runTestSuite() {
long startTime = System.currentTimeMillis();
WriterContext writerContext = new WriterContext(jsc, props, cfg,
keyGenerator, sparkSession);
writerContext.initContext(jsc);
- DagScheduler dagScheduler = new DagScheduler(workflowDag, writerContext);
+ DagScheduler dagScheduler = new DagScheduler(workflowDag, writerContext,
jsc, cfg.numRounds, cfg.delayMins);
Review comment:
@nsivabalan
Can we avoid introducing these high level arguments numRound and delayMins
to the dagScheduler ? This messes with a simpler design and adds unnecessary
overloading to the constructor.
Instead, we could do something like this
Introduce a top level yaml change around this
dag_name:
dag_rounds:
dag_intermittent_delay:
dag_props:
dag_content:
insert_node:
...
upsert_node:
...
You can then introduce a concept called RuntimeComposableDagNode that
basically wraps this concept.
Let me know.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
