n3nash commented on a change in pull request #2168:
URL: https://github.com/apache/hudi/pull/2168#discussion_r520133977
##########
File path:
hudi-integ-test/src/main/java/org/apache/hudi/integ/testsuite/converter/UpdateConverter.java
##########
@@ -35,19 +37,23 @@
private final List<String> partitionPathFields;
private final List<String> recordKeyFields;
private final int minPayloadSize;
+ private final String preCombineField;
+ private final int preCombineFieldValue;
- public UpdateConverter(String schemaStr, int minPayloadSize, List<String>
partitionPathFields,
- List<String> recordKeyFields) {
+ public UpdateConverter(String schemaStr, int minPayloadSize, List<String>
partitionPathFields,
+ List<String> recordKeyFields, String preCombineField, int
preCombineFieldValue) {
Review comment:
Can you explain why we need to introduce these 2 fields ? Also, please
comment why the preCombineFieldValue is "int" ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
