danny0405 commented on code in PR #13229:
URL: https://github.com/apache/hudi/pull/13229#discussion_r2101944222
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/BaseHoodieTableServiceClient.java:
##########
@@ -541,15 +582,15 @@ private void
completeClustering(HoodieReplaceCommitMetadata metadata,
// Only in some cases conflict resolution needs to be performed.
// So, check if preCommit method that does conflict resolution needs to
be triggered.
if (isPreCommitRequired()) {
- preCommit(metadata);
+ preCommit(replaceCommitMetadata);
}
// Update table's metadata (table)
- writeTableMetadata(table, clusteringInstant.requestedTime(), metadata);
+ writeTableMetadata(table, clusteringInstant.requestedTime(),
replaceCommitMetadata);
LOG.info("Committing Clustering {} for table {}", clusteringCommitTime,
table.getConfig().getBasePath());
- LOG.debug("Clustering {} finished with result {}", clusteringCommitTime,
metadata);
+ LOG.debug("Clustering {} finished with result {}", clusteringCommitTime,
replaceCommitMetadata);
Review Comment:
Should move the debug log under
`ClusteringUtils.transitionClusteringOrReplaceInflightToComplete`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
