nsivabalan commented on code in PR #13229:
URL: https://github.com/apache/hudi/pull/13229#discussion_r2102005313
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/action/commit/BaseCommitActionExecutor.java:
##########
@@ -310,16 +306,14 @@ protected HoodieWriteMetadata<HoodieData<WriteStatus>>
executeClustering(HoodieC
HoodieData<WriteStatus> writeStatusList = writeMetadata.getWriteStatuses();
HoodieData<WriteStatus> statuses = updateIndex(writeStatusList,
writeMetadata);
statuses.persist(config.getString(WRITE_STATUS_STORAGE_LEVEL_VALUE),
context, HoodieData.HoodieDataCacheKey.of(config.getBasePath(), instantTime));
- // triggers clustering.
-
writeMetadata.setWriteStats(statuses.map(WriteStatus::getStat).collectAsList());
-
writeMetadata.setPartitionToReplaceFileIds(getPartitionToReplacedFileIds(clusteringPlan,
writeMetadata));
- commitOnAutoCommit(writeMetadata);
- if (!writeMetadata.getCommitMetadata().isPresent()) {
- LOG.info("Found empty commit metadata for clustering with instant time "
+ instantTime);
- HoodieCommitMetadata commitMetadata =
CommitUtils.buildMetadata(writeMetadata.getWriteStats().get(),
writeMetadata.getPartitionToReplaceFileIds(),
- extraMetadata, operationType, schema.get().toString(),
getCommitActionType());
- writeMetadata.setCommitMetadata(Option.of(commitMetadata));
- }
+
+ writeMetadata.setWriteStatuses(statuses);
Review Comment:
yes, I did not want to change the flow. thats how it was before. we were
setting the status in WriteMetadata within updateIndex() call.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
