TheR1sing3un commented on code in PR #13342:
URL: https://github.com/apache/hudi/pull/13342#discussion_r2102348540
##########
hudi-common/src/main/java/org/apache/hudi/common/model/HoodieFileGroup.java:
##########
@@ -119,6 +121,10 @@ public void addLogFile(CompletionTimeQueryView
completionTimeQueryView, HoodieLo
@VisibleForTesting
public String getBaseInstantTime(CompletionTimeQueryView
completionTimeQueryView, HoodieLogFile logFile) {
if (fileSlices.isEmpty()) {
+ if
(completionTimeQueryView.getTableVersion().greaterThanOrEquals(HoodieTableVersion.EIGHT))
{
+ // no base file in the file group, use INITIAL INSTANT TIME as base
instant time
+ return HoodieActiveTimeline.INIT_INSTANT_TS;
Review Comment:
> Looks like a version compatibility issue?
Indeed, it is. Essentially, it is because the log file name of the old
version contained the base instant time of this slice, while the log file name
of the new version only contains the instant written to this file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
