TheR1sing3un commented on code in PR #13342:
URL: https://github.com/apache/hudi/pull/13342#discussion_r2104176327


##########
hudi-common/src/main/java/org/apache/hudi/common/table/view/AbstractTableFileSystemView.java:
##########
@@ -867,6 +888,10 @@ public final Stream<FileSlice> getLatestFileSlices(String 
partitionStr) {
           .flatMap(slice -> tableVersion8AndAbove()
               ? this.filterUncommittedFiles(slice, true)
               : this.filterBaseFileAfterPendingCompaction(slice, true))
+          .flatMap(slice -> tableVersion8AndAbove()
+              // for table version 8 and above, we need to filter out empty 
file slices
+              ? this.filterOutEmptyFileSlice(slice)
+              : Stream.of(slice))

Review Comment:
   should filter out the `isEmpty` slice, because this slice is not `isEmpty` 
due to previous pending compaction, but because there are no valid commits at 
all in this slice



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to