danny0405 commented on code in PR #13249:
URL: https://github.com/apache/hudi/pull/13249#discussion_r2103674893


##########
hudi-sync/hudi-hive-sync/src/main/java/org/apache/hudi/hive/HiveSyncTool.java:
##########
@@ -274,6 +281,21 @@ protected void syncHoodieTable(String tableName, boolean 
useRealtimeInputFormat,
     }
   }
 
+  private boolean isAlreadySynced(String tableName) {
+    return syncClient.getLastCommitTimeSynced(tableName)
+        .map(lastCommit -> {
+          Option<String> lastCompletion =
+              syncClient.getLastCommitCompletionTimeSynced(tableName);

Review Comment:
   Not really, you even passed the instant time instead of the completion time 
there.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to