danny0405 commented on code in PR #13249:
URL: https://github.com/apache/hudi/pull/13249#discussion_r2103707088
##########
hudi-sync/hudi-hive-sync/src/main/java/org/apache/hudi/hive/HiveSyncTool.java:
##########
@@ -274,6 +281,21 @@ protected void syncHoodieTable(String tableName, boolean
useRealtimeInputFormat,
}
}
+ private boolean isAlreadySynced(String tableName) {
+ return syncClient.getLastCommitTimeSynced(tableName)
+ .map(lastCommit -> {
+ Option<String> lastCompletion =
+ syncClient.getLastCommitCompletionTimeSynced(tableName);
Review Comment:
Not sure what we want to check here: `TimelineUtils.getCommitsTimelineAfter`
is designed to catch up some "hollow" instants before V8, so it takes a instant
time and a completion time.
But here you pass around the last synced instant time and last synced
completion time, it does not make any sense.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
