the-other-tim-brown commented on code in PR #13348:
URL: https://github.com/apache/hudi/pull/13348#discussion_r2103723021
##########
hudi-common/src/main/java/org/apache/hudi/common/table/log/block/HoodieDataBlock.java:
##########
@@ -224,7 +224,12 @@ public final <T> ClosableIterator<HoodieRecord<T>>
getRecordIterator(List<String
return allRecords;
}
- HashSet<String> keySet = new HashSet<>(keys);
+ // TODO(yihua): is this valid?
+
+ HashSet<String> keySet = new HashSet<>();
Review Comment:
If we can get back the records as a sorted iterator by key, then we can use
the input keys iterator to filter in a more efficient way to comparing the head
and popping instead of requiring to compute the hash of the key to check for
presence in the set.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
