the-other-tim-brown commented on code in PR #13348:
URL: https://github.com/apache/hudi/pull/13348#discussion_r2103723244
##########
hudi-common/src/main/java/org/apache/hudi/common/table/log/block/HoodieDataBlock.java:
##########
@@ -224,7 +224,12 @@ public final <T> ClosableIterator<HoodieRecord<T>>
getRecordIterator(List<String
return allRecords;
}
- HashSet<String> keySet = new HashSet<>(keys);
+ // TODO(yihua): is this valid?
+
+ HashSet<String> keySet = new HashSet<>();
+ while (keys.hasNext()) {
+ keySet.add(keys.next());
+ }
return FilteringIterator.getInstance(allRecords, keySet, fullKey,
this::getRecordKey);
Review Comment:
Will this exit early after all keys are found if a set of keys is provided?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
