wombatu-kun commented on code in PR #12772:
URL: https://github.com/apache/hudi/pull/12772#discussion_r2103816982
##########
hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/client/model/HoodieInternalRow.java:
##########
@@ -46,7 +46,7 @@
* allow in-place updates due to its memory layout)</li>
* </ul>
*/
-public class HoodieInternalRow extends InternalRow {
+public abstract class HoodieInternalRow extends InternalRow {
Review Comment:
> Actually, in this PR, should we keep this class untouched and avoid any
changes around internal row, by adding this so that the code compiles on both
Spark 3 and 4?
If we add this "no override" method to `HoodieInternalRow`, it will not
help, the code will not compile with Spark3, because `VariantVal` is only
introduced in Spark4.
So, if we want to support Spark4, we can not keep this class untouched and
avoid changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
