wombatu-kun commented on code in PR #12772:
URL: https://github.com/apache/hudi/pull/12772#discussion_r2103821941
##########
hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/hudi/HoodieCDCFileIndex.scala:
##########
@@ -66,7 +66,7 @@ class HoodieCDCFileIndex (override val spark: SparkSession,
// Note that CDC file splits must be sorted based on their instant
time.
// Otherwise, the resulting records may not be correct.
sparkAdapter.getSparkPartitionedFileUtils.newPartitionDirectory(
- new HoodiePartitionCDCFileGroupMapping(
+ sparkAdapter.createHoodiePartitionCDCFileGroupMapping(
Review Comment:
Explanation is here
https://github.com/apache/hudi/pull/12772#discussion_r2103820263
##########
hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/hudi/HoodieIncrementalFileIndex.scala:
##########
@@ -73,7 +73,7 @@ class HoodieIncrementalFileIndex(override val spark:
SparkSession,
foldLeft(Map[String, FileSlice]()) { (m, f) => m + (f.getFileId
-> f) }
if (c.nonEmpty) {
sparkAdapter.getSparkPartitionedFileUtils.newPartitionDirectory(
- new HoodiePartitionFileSliceMapping(partitionValues, c),
baseFileStatusesAndLogFileOnly)
+
sparkAdapter.createHoodiePartitionFileSliceMapping(partitionValues, c),
baseFileStatusesAndLogFileOnly)
Review Comment:
Explanation is here
https://github.com/apache/hudi/pull/12772#discussion_r2103820263
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
