danny0405 commented on code in PR #13346:
URL: https://github.com/apache/hudi/pull/13346#discussion_r2103886397
##########
hudi-hadoop-common/src/test/java/org/apache/hudi/common/testutils/HoodieTestTable.java:
##########
@@ -467,11 +468,19 @@ public HoodieTestTable addClean(String instantTime)
throws IOException {
public Pair<HoodieCleanerPlan, HoodieCleanMetadata>
getHoodieCleanMetadata(String commitTime, HoodieTestTableState testTableState) {
HoodieCleanerPlan cleanerPlan = new HoodieCleanerPlan(new
HoodieActionInstant(commitTime, CLEAN_ACTION, EMPTY_STRING),
- EMPTY_STRING, EMPTY_STRING, new HashMap<>(),
CleanPlanV2MigrationHandler.VERSION, new HashMap<>(), new ArrayList<>(),
Collections.EMPTY_MAP);
+ EMPTY_STRING, EMPTY_STRING, new HashMap<>(),
CleanPlanV2MigrationHandler.VERSION, new HashMap<>(),
testTableState.getPartitionsToDeleteForCleaner(commitTime),
Collections.EMPTY_MAP);
Review Comment:
should we reuse `testTableState.getPartitionsToDeleteForCleaner(commitTime)`
?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
