danny0405 commented on code in PR #13346:
URL: https://github.com/apache/hudi/pull/13346#discussion_r2103888277
##########
hudi-hadoop-common/src/test/java/org/apache/hudi/common/testutils/HoodieTestTable.java:
##########
@@ -1154,11 +1163,11 @@ public HoodieReplaceCommitMetadata doCluster(String
commitTime, Map<String, List
return replaceMetadata;
}
- public HoodieCleanMetadata doClean(String commitTime, Map<String, Integer>
partitionFileCountsToDelete) throws IOException {
- return doClean(commitTime, partitionFileCountsToDelete,
Collections.emptyMap());
+ public HoodieCleanMetadata doClean(String commitTime, Map<String, Integer>
partitionFileCountsToDelete, List<String> partitionsToBeDeleted) throws
IOException {
+ return doClean(commitTime, partitionFileCountsToDelete,
partitionsToBeDeleted, Collections.emptyMap());
Review Comment:
can we keep the method unchanged and add a new one.
##########
hudi-hadoop-common/src/test/java/org/apache/hudi/common/testutils/HoodieTestTable.java:
##########
@@ -1154,11 +1163,11 @@ public HoodieReplaceCommitMetadata doCluster(String
commitTime, Map<String, List
return replaceMetadata;
}
- public HoodieCleanMetadata doClean(String commitTime, Map<String, Integer>
partitionFileCountsToDelete) throws IOException {
- return doClean(commitTime, partitionFileCountsToDelete,
Collections.emptyMap());
+ public HoodieCleanMetadata doClean(String commitTime, Map<String, Integer>
partitionFileCountsToDelete, List<String> partitionsToBeDeleted) throws
IOException {
+ return doClean(commitTime, partitionFileCountsToDelete,
partitionsToBeDeleted, Collections.emptyMap());
}
- public HoodieCleanMetadata doClean(String commitTime, Map<String, Integer>
partitionFileCountsToDelete, Map<String, String> extraMetadata) throws
IOException {
+ public HoodieCleanMetadata doClean(String commitTime, Map<String, Integer>
partitionFileCountsToDelete, List<String> partitionsToDelete, Map<String,
String> extraMetadata) throws IOException {
Review Comment:
can we keep the method unchanged and add a new one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
