rmpifer opened a new pull request #2248: URL: https://github.com/apache/hudi/pull/2248
## *Tips* - *Thank you very much for contributing to Apache Hudi.* - *Please review https://hudi.apache.org/contributing.html before opening a pull request.* ## What is the purpose of the pull request Currently when records are deduplicated HoodieKey is chosen without respect to results of precombine method. This creates issues when using global index if partition values are different in a batch. The record can be placed in the incorrect partition since `partitionPath` in HoodieKey does not correspond to data returned by `precombine()`. https://issues.apache.org/jira/browse/HUDI-1196 ## Brief change log This change checks to see whether data returned by `precombine()` corresponds to `record1` or `record2` and creates HoodieRecord with the proper HoodieKey ## Verify this pull request *(Please pick either of the following options)* This pull request is a trivial rework / code cleanup without any test coverage. *(or)* This pull request is already covered by existing tests, such as *(please describe tests)*. (or) This change added tests and can be verified as follows: *(example:)* - *Added integration tests for end-to-end.* - *Added HoodieClientWriteTest to verify the change.* - *Manually verified the change by running a job locally.* ## Committer checklist - [ ] Has a corresponding JIRA in PR title & commit - [ ] Commit message is descriptive of the change - [ ] CI is green - [ ] Necessary doc changes done or have another open PR - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org