yihua commented on code in PR #12964:
URL: https://github.com/apache/hudi/pull/12964#discussion_r2110667125
##########
pom.xml:
##########
@@ -425,9 +424,6 @@
</excludes>
<includes>
<include>org.slf4j:slf4j-simple:*:*:test</include>
-
<include>org.apache.hbase:hbase-common:${hbase.version}</include>
Review Comment:
Could you update the comment above which is outdated now:
```
<!-- NOTE: We're banning any HBase deps versions other
than the approved ${hbase.version},
which is aimed at preventing the classpath
collisions w/ transitive deps usually) -->
<exclude>org.apache.hbase:hbase-common:*</exclude>
<exclude>org.apache.hbase:hbase-client:*</exclude>
<exclude>org.apache.hbase:hbase-server:*</exclude>
```
##########
hudi-tests-common/pom.xml:
##########
@@ -201,7 +201,12 @@
<groupId>org.apache.hadoop</groupId>
<artifactId>hadoop-hdfs-client</artifactId>
<version>${hadoop.version}</version>
- <classifier>tests</classifier>
+ <scope>test</scope>
Review Comment:
Test classes from `hadoop-hdfs-client` module are no longer needed?
##########
pom.xml:
##########
@@ -425,9 +424,6 @@
</excludes>
<includes>
<include>org.slf4j:slf4j-simple:*:*:test</include>
-
<include>org.apache.hbase:hbase-common:${hbase.version}</include>
Review Comment:
Could you revisit these remaining `hbase` usage:
- `<exclude>hbase-webapps/**</exclude>` in different POMs
- `hudi-common/pom.xml`:
```
<!-- Force to use 2.11.0 since hbase-server requires 2.7+ -->
<dependency>
<groupId>commons-io</groupId>
<artifactId>commons-io</artifactId>
<version>${commons.io.version}</version>
</dependency>
```
- `hudi-examples/hudi-examples-k8s/pom.xml`:
`<exclude>org.apache.hbase.thirdparty:*</exclude>`
- `packaging/hudi-flink-bundle/pom.xml`,
`packaging/hudi-spark-bundle/pom.xml` and make sure `hbase-default.xml` does
not appear in the bundle after this is removed:
```
<!-- hbase-default.xml comes from hbase-common, hbase related classes used
in hudi are in shaded
pattern, the default classes in hbase-default.xml can
cause ClassNotFoundException. -->
<exclude>hbase-default.xml</exclude>
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
