yihua commented on code in PR #12964:
URL: https://github.com/apache/hudi/pull/12964#discussion_r2110744364
##########
hudi-client/hudi-spark-client/src/test/java/org/apache/hudi/table/action/commit/TestUpsertPartitioner.java:
##########
@@ -311,7 +311,7 @@ public void
testUpsertPartitionerWithSmallFileHandlingWithCanIndexLogFiles() thr
.withCompactionConfig(HoodieCompactionConfig.newBuilder().compactionSmallFileSize(1024).build())
.withStorageConfig(HoodieStorageConfig.newBuilder().parquetMaxFileSize(1024).build())
.withIndexConfig(HoodieIndexConfig.newBuilder()
- .withIndexType(HoodieIndex.IndexType.HBASE)
+ .withIndexType(HoodieIndex.IndexType.INMEMORY)
Review Comment:
Sg
##########
hudi-platform-service/hudi-metaserver/hudi-metaserver-client/pom.xml:
##########
@@ -37,6 +37,11 @@
<artifactId>hudi-client-common</artifactId>
<version>${project.version}</version>
</dependency>
+ <dependency>
+ <groupId>org.apache.hadoop</groupId>
+ <artifactId>hadoop-common</artifactId>
+ <version>${hadoop.version}</version>
+ </dependency>
Review Comment:
@linliu-code to revisit this
##########
hudi-examples/hudi-examples-java/pom.xml:
##########
@@ -154,5 +154,9 @@
<version>${parquet.version}</version>
<scope>provided</scope>
</dependency>
+ <dependency>
+ <groupId>org.apache.hadoop</groupId>
+ <artifactId>hadoop-common</artifactId>
+ </dependency>
Review Comment:
Similarly, would `hudi-hadoop-common` fix the issue?
##########
hudi-common/pom.xml:
##########
@@ -354,5 +311,9 @@
<artifactId>tally-core</artifactId>
<version>${tally.version}</version>
</dependency>
+ <dependency>
+ <groupId>javax.xml.bind</groupId>
+ <artifactId>jaxb-api</artifactId>
+ </dependency>
Review Comment:
Let's use `org.jetbrains.annotations.NotNull` consistently across the code
base to avoid this dependency.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
