the-other-tim-brown commented on code in PR #13366:
URL: https://github.com/apache/hudi/pull/13366#discussion_r2113040543
##########
hudi-common/src/main/java/org/apache/hudi/common/table/read/HoodieFileGroupReader.java:
##########
@@ -181,17 +176,15 @@ private FileGroupRecordBuffer<T>
getRecordBuffer(HoodieReaderContext<T> readerCo
RecordMergeMode
recordMergeMode,
TypedProperties props,
Option<HoodieBaseFile>
baseFileOption,
- boolean hasNoLogFiles,
+ boolean hasLogFiles,
boolean isSkipMerge,
boolean
shouldUseRecordPosition,
HoodieReadStats readStats,
boolean emitDelete) {
- if (hasNoLogFiles) {
- return null;
- } else if (isSkipMerge) {
+ if (isSkipMerge) {
Review Comment:
In the current code we read directly from the base file and avoid the
overhead of creating this buffer, why change that?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
