the-other-tim-brown commented on code in PR #13366:
URL: https://github.com/apache/hudi/pull/13366#discussion_r2113087021
##########
hudi-common/src/main/java/org/apache/hudi/common/table/read/HoodieFileGroupReader.java:
##########
@@ -181,17 +176,15 @@ private FileGroupRecordBuffer<T>
getRecordBuffer(HoodieReaderContext<T> readerCo
RecordMergeMode
recordMergeMode,
TypedProperties props,
Option<HoodieBaseFile>
baseFileOption,
- boolean hasNoLogFiles,
+ boolean hasLogFiles,
boolean isSkipMerge,
boolean
shouldUseRecordPosition,
HoodieReadStats readStats,
boolean emitDelete) {
- if (hasNoLogFiles) {
- return null;
- } else if (isSkipMerge) {
+ if (isSkipMerge) {
Review Comment:
I see the value of unifying with the record buffer more clearly now and the
approach makes sense to me.
For the conversion, is there a way to have an interface that for a given
output type `O` handles `T -> O` and `BufferedRecord<T> -> O`? These can be
methods defined within the enum class `IteratorMode`. This could help minimize
the conversions required.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
