danny0405 commented on code in PR #13290:
URL: https://github.com/apache/hudi/pull/13290#discussion_r2113131540
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/config/HoodieWriteConfig.java:
##########
@@ -3471,6 +3500,8 @@ public Builder withIncrementalTableServiceEnabled(boolean
incrementalTableServic
protected void setDefaults() {
writeConfig.setDefaultValue(MARKERS_TYPE,
getDefaultMarkersType(engineType));
+ // set default for streaming writes to metadata table.
+ writeConfig.setDefaultValue(STREAMING_WRITES_TO_METADATA_TABLE,
getDefaultForStreamingWritesToMetadataTable(engineType));
Review Comment:
let's move all the default values inference to the options's inference
function, so that there is no need to maintain it in multiple places: engine
type and table version.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
