nsivabalan commented on code in PR #13290:
URL: https://github.com/apache/hudi/pull/13290#discussion_r2113200409
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/config/HoodieWriteConfig.java:
##########
@@ -3471,6 +3500,8 @@ public Builder withIncrementalTableServiceEnabled(boolean
incrementalTableServic
protected void setDefaults() {
writeConfig.setDefaultValue(MARKERS_TYPE,
getDefaultMarkersType(engineType));
+ // set default for streaming writes to metadata table.
+ writeConfig.setDefaultValue(STREAMING_WRITES_TO_METADATA_TABLE,
getDefaultForStreamingWritesToMetadataTable(engineType));
Review Comment:
ok, this is bit tricky. due to the limitation w/ ConfigProperty infra, we
can only define `noDefault()` only for `String` types. Here we are using
boolean. if not, we have to parse the boolean everytime from the string value.
the infer func makes sense only if we have noDefault right.
Prefer to leave it as is. lmk what do you think.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
