danny0405 commented on code in PR #13295:
URL: https://github.com/apache/hudi/pull/13295#discussion_r2113226565
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/metadata/HoodieBackedTableMetadataWriter.java:
##########
@@ -1370,7 +1371,9 @@ public void close() throws Exception {
protected void commitInternal(String instantTime, Map<String,
HoodieData<HoodieRecord>> partitionRecordsMap, boolean isInitializing,
Option<BulkInsertPartitioner>
bulkInsertPartitioner) {
ValidationUtils.checkState(metadataMetaClient != null, "Metadata table is
not fully initialized yet.");
- HoodieData<HoodieRecord> preppedRecords = prepRecords(partitionRecordsMap);
+ Pair<HoodieData<HoodieRecord>, List<HoodieFileGroupId>> result =
prepRecords(partitionRecordsMap);
+ HoodieData<HoodieRecord> preppedRecords = result.getKey();
+ List<HoodieFileGroupId> hoodieFileGroupIdList = result.getValue();
Review Comment:
`hoodieFileGroupIdList` is not used in anywhere.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
