danny0405 commented on code in PR #13305:
URL: https://github.com/apache/hudi/pull/13305#discussion_r2115089269


##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/WriteStatus.java:
##########
@@ -61,6 +61,8 @@ public class WriteStatus implements Serializable {
 
   private final List<Pair<HoodieRecordDelegate, Throwable>> failedRecords = 
new ArrayList<>();
 
+  // true if this WriteStatus refers to a write happening in metadata table.
+  private boolean isMetadataTable;

Review Comment:
   >Add a boolean flag to this class named isMetadataTable().
   we don't care if it is MDT or DT, what we really care about is wheter the 
write status carries on additional stats.
   
   My idea is we can have an optional stats component (maybe name it as 
IndexStats?) and for MDT we can keep it as empty, so that we can move all the 
stats related things to `IndexStats` and still keep the basic WriteStatus as 
clean.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to