danny0405 commented on code in PR #13305:
URL: https://github.com/apache/hudi/pull/13305#discussion_r2115107505
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/WriteStatus.java:
##########
@@ -61,6 +61,8 @@ public class WriteStatus implements Serializable {
private final List<Pair<HoodieRecordDelegate, Throwable>> failedRecords =
new ArrayList<>();
+ // true if this WriteStatus refers to a write happening in metadata table.
+ private boolean isMetadataTable;
Review Comment:
> eventually, we will route data table's write status to
writeclient.commit() pertaining to data table. and metadata table's write
status pertaining to metadata table to writeClient.commit() pertaining to
metadata table.
Not sure why we rely on the flag in write status to route the call to
`#commit`, shouldn't we differentiate by checking the table path? By using
`HoodieTableMetadata.isMetadataTable` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
