danny0405 commented on code in PR #13380:
URL: https://github.com/apache/hudi/pull/13380#discussion_r2122374276
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/HoodieTable.java:
##########
@@ -142,12 +143,13 @@ public abstract class HoodieTable<T, I, K, O> implements
Serializable {
private final InstantGenerator instantGenerator;
private final InstantFileNameGenerator instantFileNameGenerator;
private final InstantFileNameParser instantFileNameParser;
+ private transient TransactionManager transactionManager;
Review Comment:
> then can we see if some of this code can be pulled out of the table layer
instead of passing the txnManager down
+1, let's get rid of the txn manager from table, it's dangerous to get a
dead-lock if the caller(maybe write client) already holds a lock.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
