the-other-tim-brown commented on code in PR #13380:
URL: https://github.com/apache/hudi/pull/13380#discussion_r2122421826
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/HoodieTable.java:
##########
@@ -723,11 +736,17 @@ void rollbackInflightInstant(HoodieInstant
inflightInstant,
* @param inflightInstant Inflight Compaction Instant
*/
public void rollbackInflightLogCompaction(HoodieInstant inflightInstant,
Function<String, Option<HoodiePendingRollbackInfo>>
getPendingRollbackInstantFunc) {
- final String commitTime =
getPendingRollbackInstantFunc.apply(inflightInstant.requestedTime()).map(entry
- -> entry.getRollbackInstant().requestedTime())
- .orElseGet(() -> getMetaClient().createNewInstantTime());
- scheduleRollback(context, commitTime, inflightInstant, false,
config.shouldRollbackUsingMarkers(),
- false);
+ transactionManager.beginTransaction(Option.empty(), Option.empty());
Review Comment:
We create the inflight rollback instant within the transaction now so we
cannot pass that in
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
