the-other-tim-brown commented on code in PR #13380:
URL: https://github.com/apache/hudi/pull/13380#discussion_r2126819893
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/BaseHoodieTableServiceClient.java:
##########
@@ -1170,7 +1175,12 @@ public void rollbackFailedBootstrap() {
if (instant.isPresent() && compareTimestamps(instant.get(),
LESSER_THAN_OR_EQUALS,
HoodieTimeline.FULL_BOOTSTRAP_INSTANT_TS)) {
LOG.info("Found pending bootstrap instants. Rolling them back");
- table.rollbackBootstrap(context, createNewInstantTime());
+ txnManager.beginTransaction(Option.empty(), Option.empty());
Review Comment:
I can pick this up when doing some more cleanup. I have some similar ideas
where we can also generate the time within the txnManager and see if that can
be a way to prevent any future issues where time generation happens outside of
a lock.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
