lokeshj1703 commented on code in PR #13286:
URL: https://github.com/apache/hudi/pull/13286#discussion_r2135852968
##########
hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/metadata/SparkHoodieBackedTableMetadataWriter.java:
##########
@@ -161,6 +185,13 @@ protected void upsertAndCommit(BaseHoodieWriteClient<?,
JavaRDD<HoodieRecord>, ?
writeClient.commit(instantTime, writeStatusJavaRDD, Option.empty(),
DELTA_COMMIT_ACTION, Collections.emptyMap());
}
+ @Override
+ protected void upsertAndCommit(BaseHoodieWriteClient<?,
JavaRDD<HoodieRecord>, ?, JavaRDD<WriteStatus>> writeClient, String
instantTime, JavaRDD<HoodieRecord> preppedRecordInputs,
+ List<HoodieFileGroupId>
mdtFileGroupsIdsToUpdate) {
+ JavaRDD<WriteStatus> writeStatusJavaRDD =
((SparkRDDMetadataWriteClient)writeClient).upsertPreppedRecords(preppedRecordInputs,
instantTime, Option.of(mdtFileGroupsIdsToUpdate));
Review Comment:
Addressed
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/metadata/HoodieBackedTableMetadataWriter.java:
##########
@@ -200,12 +218,17 @@ protected
HoodieBackedTableMetadataWriter(StorageConfiguration<?> storageConf,
}
}
ValidationUtils.checkArgument(!initialized || this.metadata != null, "MDT
Reader should have been opened post initialization");
+
+ this.metadataIndexGenerator = streamingWrites ?
Option.of(getMetadataIndexGenerator()) : Option.empty();
+ this.streamingWritesEnabled = streamingWrites;
}
List<MetadataPartitionType> getEnabledPartitions(HoodieMetadataConfig
metadataConfig, HoodieTableMetaClient metaClient) {
return MetadataPartitionType.getEnabledPartitions(metadataConfig,
metaClient);
}
+ abstract MetadataIndexGenerator getMetadataIndexGenerator();
Review Comment:
Addressed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
