nsivabalan commented on code in PR #13286:
URL: https://github.com/apache/hudi/pull/13286#discussion_r2136689110
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/metadata/HoodieTableMetadataWriter.java:
##########
@@ -36,6 +39,37 @@
*/
public interface HoodieTableMetadataWriter<I,O> extends Serializable,
AutoCloseable {
+ /**
+ * Starts a new commit in metadata table for optimized write flow.
Review Comment:
we might actually fold it within our abstraction we have planned to write to
metadata table. rather than BaseHoodieWriteClient directly calling metadata
table write client.startCommit() directly,
just when we are looking to start the streaming write to metadata table, the
abstraction (named
[HoodieMetadataWriteWrapper](https://github.com/apache/hudi/pull/13402)).
This is to unify the flows across ingestion writers and table services. For
ingestion service, we can call startCommit in mdt right away when we call write
client.startcommit in data table. but for table services, we can't do that. We
have to wait until the table service execution starts. So, after going back and
forth, I unified the logic across both (ingestion writers and table services).
Just when we call streaming write to metadata table, we will create a new
HoodieMetadataWriter and we will start a new commit with MDT
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
