the-other-tim-brown commented on code in PR #13407:
URL: https://github.com/apache/hudi/pull/13407#discussion_r2137905442
##########
hudi-client/hudi-client-common/src/test/java/org/apache/hudi/utils/HoodieWriterClientTestHarness.java:
##########
@@ -385,15 +385,16 @@ protected HoodieWriteConfig
getRollbackMarkersAndConsistencyGuardWriteConfig(
.withProperties(properties).build();
}
- protected HoodieWriteConfig getConsistencyCheckWriteConfig(boolean
enableOptimisticConsistencyGuard) {
- return !enableOptimisticConsistencyGuard ? (getConfigBuilder()
-
.withConsistencyGuardConfig(ConsistencyGuardConfig.newBuilder().withConsistencyCheckEnabled(true)
-
.withMaxConsistencyCheckIntervalMs(1).withInitialConsistencyCheckIntervalMs(1).withEnableOptimisticConsistencyGuard(enableOptimisticConsistencyGuard).build())
- .build()) : (getConfigBuilder()
-
.withConsistencyGuardConfig(ConsistencyGuardConfig.newBuilder().withConsistencyCheckEnabled(true)
-
.withEnableOptimisticConsistencyGuard(enableOptimisticConsistencyGuard)
- .withOptimisticConsistencyGuardSleepTimeMs(1).build())
- .build());
+ protected HoodieWriteConfig getConsistencyCheckWriteConfig(boolean
enableOptimisticConsistencyGuard, boolean populateMetaFields) {
Review Comment:
If you don't specify it, a new write client will try to change this table
property from false to true which causes a failure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
