lokeshj1703 commented on code in PR #13436:
URL: https://github.com/apache/hudi/pull/13436#discussion_r2149878529
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/io/HoodieAppendHandle.java:
##########
@@ -194,8 +210,7 @@ private Option<FileSlice>
populateWriteStatAndFetchFileSlice(HoodieRecord record
prevCommit = instantTime;
if (hoodieTable.getMetaClient().getTableConfig().isCDCEnabled()) {
// the cdc reader needs the base file metadata to have deterministic
update sequence.
- TableFileSystemView.SliceView rtView = hoodieTable.getSliceView();
- fileSlice = rtView.getLatestFileSlice(partitionPath, fileId);
+ fileSlice = getFileSlice();
Review Comment:
I am not sure why this is required?
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/IndexStats.java:
##########
@@ -0,0 +1,59 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hudi.client;
+
+import org.apache.hudi.common.model.HoodieRecordDelegate;
+
+import java.io.Serializable;
+import java.util.ArrayList;
+import java.util.HashMap;
+import java.util.List;
+import java.util.Map;
+
+/**
+ * Class to hold all index stats required to generate Metadata records for all
enabled partitions.
+ * Supported stats are record level index stats and secondary index stats.
+ */
+public class IndexStats implements Serializable {
+ private static final long serialVersionUID = 1L;
+
+ private final List<HoodieRecordDelegate> writtenRecordDelegates = new
ArrayList<>();
+ private final Map<String, List<SecondaryIndexStats>> secondaryIndexStats =
new HashMap<>();
+
+ void addHoodieRecordDelegate(HoodieRecordDelegate hoodieRecordDelegate) {
+ this.writtenRecordDelegates.add(hoodieRecordDelegate);
+ }
+
+ public List<HoodieRecordDelegate> getWrittenRecordDelegates() {
+ return writtenRecordDelegates;
+ }
+
+ public void addSecondaryIndexStats(String secondaryIndexPartitionPath,
String recordKey, String secondaryIndexValue, boolean isDeleted) {
+ secondaryIndexStats.computeIfAbsent(secondaryIndexPartitionPath, k -> new
ArrayList<>())
Review Comment:
Addressed
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/IndexStats.java:
##########
@@ -0,0 +1,59 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hudi.client;
+
+import org.apache.hudi.common.model.HoodieRecordDelegate;
+
+import java.io.Serializable;
+import java.util.ArrayList;
+import java.util.HashMap;
+import java.util.List;
+import java.util.Map;
+
+/**
+ * Class to hold all index stats required to generate Metadata records for all
enabled partitions.
+ * Supported stats are record level index stats and secondary index stats.
+ */
+public class IndexStats implements Serializable {
+ private static final long serialVersionUID = 1L;
+
+ private final List<HoodieRecordDelegate> writtenRecordDelegates = new
ArrayList<>();
+ private final Map<String, List<SecondaryIndexStats>> secondaryIndexStats =
new HashMap<>();
+
+ void addHoodieRecordDelegate(HoodieRecordDelegate hoodieRecordDelegate) {
+ this.writtenRecordDelegates.add(hoodieRecordDelegate);
+ }
+
+ public List<HoodieRecordDelegate> getWrittenRecordDelegates() {
+ return writtenRecordDelegates;
+ }
+
+ public void addSecondaryIndexStats(String secondaryIndexPartitionPath,
String recordKey, String secondaryIndexValue, boolean isDeleted) {
+ secondaryIndexStats.computeIfAbsent(secondaryIndexPartitionPath, k -> new
ArrayList<>())
+ .add(new SecondaryIndexStats(recordKey, secondaryIndexValue,
isDeleted));
+ }
+
+ public Map<String, List<SecondaryIndexStats>> getSecondaryIndexStats() {
+ return secondaryIndexStats;
+ }
+
+ void clear() {
+ this.writtenRecordDelegates.clear();
Review Comment:
Addressed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
