lokeshj1703 commented on code in PR #13436:
URL: https://github.com/apache/hudi/pull/13436#discussion_r2149878529
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/io/HoodieAppendHandle.java:
##########
@@ -194,8 +210,7 @@ private Option<FileSlice>
populateWriteStatAndFetchFileSlice(HoodieRecord record
prevCommit = instantTime;
if (hoodieTable.getMetaClient().getTableConfig().isCDCEnabled()) {
// the cdc reader needs the base file metadata to have deterministic
update sequence.
- TableFileSystemView.SliceView rtView = hoodieTable.getSliceView();
- fileSlice = rtView.getLatestFileSlice(partitionPath, fileId);
+ fileSlice = getFileSlice();
Review Comment:
Could not locate it. I think @danny0405 might have context?
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/io/HoodieMergeHandle.java:
##########
@@ -452,6 +458,51 @@ protected HoodieRecord<T> updateFileName(HoodieRecord<T>
record, Schema schema,
return record.prependMetaFields(schema, targetSchema, metadataValues,
prop);
}
+ private void trackMetadataIndexStats(Option<HoodieKey> hoodieKeyOpt,
Option<HoodieRecord> combinedRecordOpt, Option<HoodieRecord<T>> oldRecordOpt,
boolean isDelete) {
+ if (!config.isSecondaryIndexEnabled() || secondaryIndexDefns.isEmpty() ||
!config.isMetadataStreamingWritesEnabled(hoodieTable.getMetaClient().getTableConfig().getTableVersion()))
{
Review Comment:
Addressed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
