linliu-code commented on code in PR #13427:
URL: https://github.com/apache/hudi/pull/13427#discussion_r2150742956
##########
hudi-common/src/main/java/org/apache/hudi/common/table/log/block/HoodieHFileDataBlock.java:
##########
@@ -197,9 +199,15 @@ protected <T> ClosableIterator<HoodieRecord<T>>
lookupRecords(List<String> sorte
blockContentLoc.getContentPositionInLogFile(),
blockContentLoc.getBlockSize());
+ // HFile BlockCache key is based on the name of the file. The inlinefs
path has the format
+ //
inlinefs://<path_to_outer_file>/<outer_file_scheme>/?start_offset=start_offset>&length=<length>
whose filename
+ // component is parsed as "?start_offset=start_offset>&length=<length>"
ignoring the actual outer file itself.
+ // To keep this unique (as cache keys should be unique for each file), we
add a hash which is calculated from the
+ // entire filename. So the cache key would now be
?start_offset=start_offset>&length=<length>&pathHash=<hash>
Review Comment:
same typo
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
