linliu-code commented on code in PR #13427: URL: https://github.com/apache/hudi/pull/13427#discussion_r2150771609
########## hudi-common/src/main/java/org/apache/hudi/io/storage/HoodieAvroHFileReader.java: ########## @@ -83,6 +87,11 @@ public class HoodieAvroHFileReader extends HoodieAvroFileReaderBase implements H private static final Logger LOG = LoggerFactory.getLogger(HoodieAvroHFileReader.class); + // The global block cache instance used across all HFile readers + private static BlockCache GLOBAL_HFILE_BLOCK_CACHE; Review Comment: 1. Why don't we just make it per file? After a file has been read, why do we need to keep its content in the cache? 2. We have removed all the hbase dependencies, does it require us to bring some dependency back? If so, we probably cannot do it. Or just implement one by ourselves. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
