the-other-tim-brown commented on code in PR #13445:
URL: https://github.com/apache/hudi/pull/13445#discussion_r2153542902
##########
hudi-common/src/main/java/org/apache/hudi/common/engine/HoodieReaderContext.java:
##########
@@ -378,6 +378,16 @@ public Comparable getOrderingValue(T record,
*/
public abstract HoodieRecord<T> constructHoodieRecord(BufferedRecord<T>
bufferedRecord);
+ /**
+ * Constructs a new {@link HoodieRecord} based on the given record and
schema.
+ *
+ * @param record The engine-specific row.
+ * @param schema The Avro schema of the record.
+ * @param orderingFieldName The name of the ordering field, if any.
+ * @return A new instance of {@link HoodieRecord}.
+ */
+ public abstract HoodieRecord<T> constructHoodieRecord(T record, Schema
schema, Option<String> orderingFieldName);
Review Comment:
Another option is to have the FGReader return BufferedRecords directly which
will already have this context for whether it represents a delete for that row.
There are some other changes that may need to come with that like making the
ordering value lookup lazy to avoid extra overhead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
