linliu-code commented on code in PR #13445:
URL: https://github.com/apache/hudi/pull/13445#discussion_r2152944129


##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/table/format/FlinkRowDataReaderContext.java:
##########
@@ -195,6 +195,16 @@ public HoodieRecord<RowData> 
constructHoodieRecord(BufferedRecord<RowData> buffe
     return new HoodieFlinkRecord(hoodieKey, operation, 
bufferedRecord.getOrderingValue(), rowData);
   }
 
+  @Override
+  public HoodieRecord<RowData> constructHoodieRecord(RowData rowData, Schema 
schema, Option<String> orderingFieldName) {
+    HoodieOperation operation = 
HoodieOperation.fromValue(rowData.getRowKind().toByteValue());
+    HoodieKey hoodieKey = new HoodieKey(getRecordKey(rowData, schema), 
partitionPath);
+    if (operation == HoodieOperation.DELETE) {
+      return new HoodieEmptyRecord<>(hoodieKey, HoodieOperation.DELETE, 
getOrderingValue(rowData, schema, orderingFieldName), 
HoodieRecord.HoodieRecordType.FLINK);
+    }

Review Comment:
   We probably can use `HoodieDeleteHelper.createDeleteRecord` function.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to