the-other-tim-brown commented on code in PR #13469:
URL: https://github.com/apache/hudi/pull/13469#discussion_r2160655721
##########
hudi-common/src/main/java/org/apache/hudi/common/table/read/FileGroupRecordBuffer.java:
##########
@@ -110,7 +112,14 @@ protected FileGroupRecordBuffer(HoodieReaderContext<T>
readerContext,
this.payloadClass = Option.empty();
}
this.orderingFieldName = orderingFieldName;
+ // Ensure that ordering field is populated for mergers and legacy payloads
+ orderingFieldName.ifPresent(orderingField -> {
Review Comment:
The file group reader doesn't handle any of the merging so it makes more
sense to keep this all in the `FileGroupRecordBuffer`. The `orderingFieldName`
is just used in the FileGroupReader as an input when constructing the
BufferedRecord iterator
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
