danny0405 commented on code in PR #13469:
URL: https://github.com/apache/hudi/pull/13469#discussion_r2162795309
##########
hudi-common/src/main/java/org/apache/hudi/common/util/ConfigUtils.java:
##########
@@ -79,12 +79,12 @@ public class ConfigUtils {
*/
public static String getOrderingField(Properties properties) {
String orderField = null;
- if
(properties.containsKey(HoodiePayloadProps.PAYLOAD_ORDERING_FIELD_PROP_KEY)) {
- orderField =
properties.getProperty(HoodiePayloadProps.PAYLOAD_ORDERING_FIELD_PROP_KEY);
- } else if
(properties.containsKey("hoodie.datasource.write.precombine.field")) {
+ if (properties.containsKey("hoodie.datasource.write.precombine.field")) {
orderField =
properties.getProperty("hoodie.datasource.write.precombine.field");
} else if
(properties.containsKey(HoodieTableConfig.PRECOMBINE_FIELD.key())) {
orderField =
properties.getProperty(HoodieTableConfig.PRECOMBINE_FIELD.key());
+ } else if
(properties.containsKey(HoodiePayloadProps.PAYLOAD_ORDERING_FIELD_PROP_KEY)) {
Review Comment:
> So, why can't we just rely on only the table property here and ignore
other options.
we want to keep backward compatibility here, we can remove all the others
except the others when the write config got removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
