the-other-tim-brown commented on PR #13450:
URL: https://github.com/apache/hudi/pull/13450#issuecomment-3019975851

   > Are we sure that baseFileOnlyview().getLatestBaseFile(partitionPath, 
fileId) returns a non existant base file from pending compaction?
   > 
   > From what I see, it should not
   > 
   > 
https://github.com/apache/hudi/blob/33a7b845bcd30f823d026b9f19e20554fe3cf10e/hudi-common/src/main/java/org/apache/hudi/common/table/view/AbstractTableFileSystemView.java#L793
   > 
   > -> calls
   > 
   > 
https://github.com/apache/hudi/blob/33a7b845bcd30f823d026b9f19e20554fe3cf10e/hudi-common/src/main/java/org/apache/hudi/common/table/view/AbstractTableFileSystemView.java#L1599
   > 
   > -> calls
   > 
   > 
https://github.com/apache/hudi/blob/33a7b845bcd30f823d026b9f19e20554fe3cf10e/hudi-common/src/main/java/org/apache/hudi/common/table/view/AbstractTableFileSystemView.java#L1478
   > 
   > -> calls
   > 
   > 
https://github.com/apache/hudi/blob/33a7b845bcd30f823d026b9f19e20554fe3cf10e/hudi-common/src/main/java/org/apache/hudi/common/table/view/AbstractTableFileSystemView.java#L1486
   > 
   > where we do ignore base files from pending compaction.
   
   @nsivabalan this is exactly the issue, it needs to return the base file from 
the completed commit and not an empty option


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to