danny0405 commented on code in PR #13566:
URL: https://github.com/apache/hudi/pull/13566#discussion_r2212007959
##########
hudi-common/src/main/java/org/apache/hudi/common/table/log/HoodieMergedLogRecordReader.java:
##########
@@ -124,6 +129,17 @@ static Option<KeySpec> createKeySpec(Option<Predicate>
filter) {
}
}
+ static List<String> getNewFullKeys(List<String> fullKeys,
+ HoodieReaderContext readerContext,
+ FileGroupRecordBuffer recordBuffer) {
+ if (readerContext.getReuseBuffer()) {
+ return fullKeys.stream()
+ .filter(key -> !recordBuffer.containsLogRecord(key))
Review Comment:
I didn't quite get this part, if we have 2 queries from the FG reader with
different keys, and query values has overlappings for logs, does it mean the
secondary query will just skip these overlappings?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
