yihua commented on code in PR #13556:
URL: https://github.com/apache/hudi/pull/13556#discussion_r2213632139


##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/io/FileGroupReaderBasedMergeHandle.java:
##########
@@ -189,7 +190,6 @@ public void write() {
         this.insertRecordsWritten = readStats.getNumInserts();
         this.updatedRecordsWritten = readStats.getNumUpdates();
         this.recordsDeleted = readStats.getNumDeletes();
-        this.recordsWritten = readStats.getNumInserts() + 
readStats.getNumUpdates();

Review Comment:
   `FileGroupReaderBasedAppendHandle` also does `this.recordsWritten = 
readStats.getNumInserts() + readStats.getNumUpdates();`.  Should that be 
changed now or the append handle reads log files only for log compaction so for 
append handle the record written is still correctly derived?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to