yihua commented on code in PR #13556:
URL: https://github.com/apache/hudi/pull/13556#discussion_r2213691485


##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/io/FileGroupReaderBasedMergeHandle.java:
##########
@@ -177,6 +177,7 @@ public void write() {
             writeToFile(record.getKey(), record, writeSchemaWithMetaFields,
                 config.getPayloadConfig().getProps(), preserveMetadata);
             writeStatus.markSuccess(record, recordMetadata);
+            recordsWritten++;

Review Comment:
   Do we have a test case covering insert stats based on the inserts in the log 
file and non-update records in the base file?  So that in case someone breaks 
the behavior, the test case catches that?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to