danny0405 commented on code in PR #13526:
URL: https://github.com/apache/hudi/pull/13526#discussion_r2222179712
##########
hudi-common/src/main/java/org/apache/hudi/common/table/log/block/HoodieDeleteBlock.java:
##########
@@ -142,11 +142,18 @@ private byte[] serializeV3() throws IOException {
HoodieDeleteRecordList.Builder recordListBuilder =
HOODIE_DELETE_RECORD_LIST_BUILDER_STUB.get();
HoodieDeleteRecord.Builder recordBuilder =
HOODIE_DELETE_RECORD_BUILDER_STUB.get();
List<HoodieDeleteRecord> deleteRecordList =
Arrays.stream(getRecordsToDelete())
- .map(record -> HoodieDeleteRecord.newBuilder(recordBuilder)
+ .map(record -> {
+ List<Comparable> orderingVals = record.getOrderingValue() instanceof
Comparables
Review Comment:
not a fan of `instanceof` per record, after this patch, the
`record.getOrderingValue()` should always be `Comparables` right? If this is
true, could we switch it's return type to just `Comparables`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
