danny0405 commented on code in PR #13526:
URL: https://github.com/apache/hudi/pull/13526#discussion_r2222203052


##########
hudi-common/src/main/java/org/apache/hudi/common/engine/HoodieReaderContext.java:
##########
@@ -479,6 +481,15 @@ public final UnaryOperator<T> projectRecord(Schema from, 
Schema to) {
     return projectRecord(from, to, Collections.emptyMap());
   }
 
+  /**
+   * Converts the comparable values in Comparables to the specific engine type
+   */
+  public final Comparable convertValueToEngineType(Comparable value) {
+    return value instanceof Comparables

Review Comment:
   Maybe we just add a new method 
`convertOrderingValueToEngineType(OrderingValue)` so that we can get rid of the 
`instanceof` per record.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to