nsivabalan commented on code in PR #13529:
URL: https://github.com/apache/hudi/pull/13529#discussion_r2223703475
##########
hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/hudi/HoodieHadoopFsRelationFactory.scala:
##########
@@ -424,15 +442,16 @@ abstract class
BaseHoodieCopyOnWriteIncrementalHadoopFsRelationFactory(override
}
-class HoodieCopyOnWriteIncrementalHadoopFsRelationFactory(override val
sqlContext: SQLContext,
- override val
metaClient: HoodieTableMetaClient,
- override val
options: Map[String, String],
- override val
schemaSpec: Option[StructType],
- isBootstrap: Boolean)
- extends BaseHoodieCopyOnWriteIncrementalHadoopFsRelationFactory(sqlContext,
metaClient, options, schemaSpec, isBootstrap) {
+abstract class HoodieCopyOnWriteIncrementalHadoopFsRelationFactory(override
val sqlContext: SQLContext,
+
override val metaClient: HoodieTableMetaClient,
+
override val options: Map[String, String],
+
override val schemaSpec: Option[StructType],
+
isBootstrap: Boolean,
+
mergeOnReadIncrementalRelation: MergeOnReadIncrementalRelation)
+ extends HoodieBaseCopyOnWriteIncrementalHadoopFsRelationFactory(sqlContext,
metaClient, options, schemaSpec, isBootstrap) {
private val incrementalFileIndex = new HoodieIncrementalFileIndex(
- sparkSession, metaClient, schemaSpec, options, fileStatusCache, false,
true)
+ sparkSession, metaClient, schemaSpec, options, fileStatusCache, false,
true, mergeOnReadIncrementalRelation)
Review Comment:
hmmm, I see. can we clean that up as well since we are fixing class
hierarchy anyways as part of this exercise
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
