nsivabalan commented on code in PR #13529:
URL: https://github.com/apache/hudi/pull/13529#discussion_r2223705439
##########
hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/hudi/DefaultSource.scala:
##########
@@ -334,29 +340,13 @@ object DefaultSource {
resolveBaseFileOnlyRelation(sqlContext, globPaths, userSchema,
metaClient, parameters)
}
case (COPY_ON_WRITE, QUERY_TYPE_INCREMENTAL_OPT_VAL, _) =>
- if (SparkConfigUtils.containsConfigProperty(parameters,
INCREMENTAL_READ_TABLE_VERSION)) {
- val writeTableVersion =
Integer.parseInt(parameters(INCREMENTAL_READ_TABLE_VERSION.key))
- if (writeTableVersion >= HoodieTableVersion.EIGHT.versionCode())
{
- if (useNewParquetFileFormat) {
- new HoodieCopyOnWriteIncrementalHadoopFsRelationFactory(
- sqlContext, metaClient, parameters, userSchema,
isBootstrappedTable).build()
- } else {
- new IncrementalRelationV2(sqlContext, parameters,
userSchema, metaClient, RangeType.CLOSED_CLOSED)
- }
- } else {
- new IncrementalRelationV1(sqlContext, parameters, userSchema,
metaClient)
- }
- } else {
- if (metaClient.getTableConfig.getTableVersion.versionCode() >=
HoodieTableVersion.EIGHT.versionCode()) {
- if (useNewParquetFileFormat) {
- new HoodieCopyOnWriteIncrementalHadoopFsRelationFactory(
- sqlContext, metaClient, parameters, userSchema,
isBootstrappedTable).build()
- } else {
- new IncrementalRelationV2(sqlContext, parameters,
userSchema, metaClient, RangeType.CLOSED_CLOSED)
- }
- } else {
- new IncrementalRelationV1(sqlContext, parameters, userSchema,
metaClient)
- }
+ (hudiOneTable, useNewParquetFileFormat) match {
+ case (true, true) => new
HoodieCopyOnWriteIncrementalHadoopFsRelationFactoryV2(
Review Comment:
gotcha.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
