danny0405 commented on code in PR #13583:
URL: https://github.com/apache/hudi/pull/13583#discussion_r2224130838
##########
hudi-common/src/main/java/org/apache/hudi/metadata/MetadataPartitionType.java:
##########
@@ -202,7 +202,7 @@ public String getPartitionPath(HoodieTableMetaClient
metaClient, String indexNam
SECONDARY_INDEX(HoodieTableMetadataUtil.PARTITION_NAME_SECONDARY_INDEX_PREFIX,
"secondary-index-", 7) {
@Override
public boolean isMetadataPartitionEnabled(HoodieMetadataConfig
metadataConfig) {
- return metadataConfig.isSecondaryIndexEnabled();
+ return metadataConfig.isSecondaryIndexEnabled() &&
StringUtils.nonEmpty(metadataConfig.getSecondaryIndexColumn());
Review Comment:
Okay, but usually we do not compromise on the core APIs just because of
tests, is it easy to fix these tests then?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
