linliu-code commented on code in PR #13517:
URL: https://github.com/apache/hudi/pull/13517#discussion_r2225225508
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/io/HoodieCreateHandle.java:
##########
@@ -133,6 +133,10 @@ public boolean canWrite(HoodieRecord record) {
@Override
protected void doWrite(HoodieRecord record, Schema schema, TypedProperties
props) {
Option<Map<String, String>> recordMetadata = record.getMetadata();
+ // Track event time metadata.
+ if (trackEventTimeWatermark && eventTimeFieldNameOpt.isPresent()) {
+ recordMetadata = appendEventTimeMetadata(record, recordMetadata);
Review Comment:
Currently only Avro data is supported to track event time, which matches
existing behavior. Supporting other types like InternalRow, ArrayWritable, etc,
we need to generic support to extract column value, which should be done after
FG reader based handle is used.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
