linliu-code commented on code in PR #13517:
URL: https://github.com/apache/hudi/pull/13517#discussion_r2225246395
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/io/HoodieWriteHandle.java:
##########
@@ -336,4 +352,51 @@ protected static Option<IndexedRecord>
toAvroRecord(HoodieRecord record, Schema
return Option.empty();
}
}
+
+ boolean shouldTrackEventTimeWaterMarkerByPayload(HoodieTableMetaClient
metaClient) {
+ // Only for event time ordering mode.
+ if (metaClient.getTableConfig().getRecordMergeMode()
+ != RecordMergeMode.EVENT_TIME_ORDERING) {
+ return false;
+ }
+
+ // Only when `DefaultHoodieRecordPayload` was the payload class.
Review Comment:
Ok, will remove. Note that then we increase the scope of this behavior from
payload based to Event time merge mode based table.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
